<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125291/">https://git.reviewboard.kde.org/r/125291/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 17th, 2015, 7:31 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">do you intend to test for "QWindow::flags() & Qt::FramelessWindowHint"?
(This would cover all unmanaged windows as well as docks and the pseudo-popups/tooltips, plasmashell seems to be so addicted to)</p></pre>
</blockquote>
<p>On September 17th, 2015, 7:45 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: you oc. want to exclude desktops then, but afair Qt::Desktop matches the root window on X11 - no idea about wayland.</p></pre>
</blockquote>
<p>On September 18th, 2015, 8:56 vorm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think on x11 is enough to test for dock.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on wayland without using kwayland, no idea</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, I meant: "platform agnostic and better than checking for panelview".
Right now, you're testing for docks and unmanaged windows on x11, what's pretty close to Qt::FramelessWindowHint (minus the desktop). Since "unmanaged" usually means "popups" but plasma popups are occasionally not and krunner is sometimes a dock and sometiems a normal window, I thought this might be the more general and better match.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On September 17th, 2015, 4:57 nachm. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 4:57 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the reason popups and tooltips position themselves some pixels lower than they should is that dialog has a check if the window that shows the item it's positioning relative to is a panel. but is using kwininfo for that, that of course doesn't work on wayland.
currently the patch checks with the metaobject if the qwindow inherits "panelview" and it works, but it's quite horrible.
can't use kwayland from there so don't know a proper way to do it.. maybe will end up exporting some magic property...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(8d4f508)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125291/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>