Review Request 125626: New activity switcher UI

[Ivan Čukić]

> On Oct. 13, 2015, 6:01 p.m., David Edmundson wrote:
> > imports/activitymanager/switcherbackend.cpp, line 334
> > <https://git.reviewboard.kde.org/r/125626/diff/1/?file=410895#file410895line334>
> >
> >     I think this whole thing with the callback and the recursion and now this extra guard are lot more complex than they need to be.
> >     
> >     Now we've got that guard to stop that infinite recursion bug if we can't save and it's growing to be a bit of a monster.
> >     
> >     Registering a a QQuickImageProvider with
> >     ForceAsynchronousImageLoading (so you can just exec() in the main method without blocking) will probably be both simpler code and more robust
> >     
> >     (also given KPreviewJob has a built in image cache, I think there's a possibility we're caching a cache here though I've not checked that properly)

Added a TODO regarding this


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125626/#review86815
-----------------------------------------------------------


On Oct. 13, 2015, 8:58 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125626/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 8:58 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is based on the VDG (Andrew's) mockup.
> 
> - Activities have more contextual information
> - Configuration and activity creation interface is the same as in activities KCM
> - Fixed the issue of plasma locking when Qt decides will-I-won't-I (the relayout loop when it decides whether to show a scroll-bar or not)
> 
> It requires the latest KActivities master.
> 
> Latest:
> ![New shot](http://ibin.co/2IwP3j7dcjPe)
> 
> Previous:
> ![Shot](http://ibin.co/2IvS4TSHzgKE)
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 9317b0e 
>   desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml 523aba6 
>   desktoppackage/contents/activitymanager/ActivityItem.qml 526716c 
>   desktoppackage/contents/activitymanager/ActivityList.qml e8bf5f0 
>   desktoppackage/contents/activitymanager/ActivityManager.qml ff5cdc1 
>   desktoppackage/contents/activitymanager/ControlButton.qml 1e9854f 
>   desktoppackage/contents/activitymanager/Heading.qml be95b9e 
>   desktoppackage/contents/activitymanager/StoppedActivityItem.qml c1a417f 
>   desktoppackage/contents/activitymanager/static.js 0eaab96 
>   imports/activitymanager/switcherbackend.h 846862e 
>   imports/activitymanager/switcherbackend.cpp 736fe67 
> 
> Diff: https://git.reviewboard.kde.org/r/125626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151014/40643e8e/attachment.html>