<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125626/">https://git.reviewboard.kde.org/r/125626/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On October 13th, 2015, 6:01 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  


<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/125626/diff/1/?file=410895#file410895line334" style="color: black; font-weight: bold; text-decoration: underline;">imports/activitymanager/switcherbackend.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPixmap SwitcherBackend::wallpaperThumbnail(const QString &path, int width, int height,</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">308</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QPixmap</span> <span class="n">SwitcherBackend</span><span class="o">::</span><span class="n">wallpaperThumbnail</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">path</span><span class="p">,</span> <span class="kt">int</span> <span class="n">width</span><span class="p">,</span> <span class="kt">int</span> <span class="n">height</span><span class="p">,</span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">332</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QPixmap</span> <span class="n">SwitcherBackend</span><span class="o">::</span><span class="n">wallpaperThumbnail</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">path</span><span class="p">,</span> <span class="kt">int</span> <span class="n">width</span><span class="p">,</span> <span class="kt">int</span> <span class="n">height</span><span class="p">,</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think this whole thing with the callback and the recursion and now this extra guard are lot more complex than they need to be.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now we've got that guard to stop that infinite recursion bug if we can't save and it's growing to be a bit of a monster.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Registering a a QQuickImageProvider with
ForceAsynchronousImageLoading (so you can just exec() in the main method without blocking) will probably be both simpler code and more robust</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(also given KPreviewJob has a built in image cache, I think there's a possibility we're caching a cache here though I've not checked that properly)</p></pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added a TODO regarding this</p></pre>
<br />




<p>- Ivan</p>


<br />
<p>On October 13th, 2015, 8:58 p.m. UTC, Ivan Čukić wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Marco Martin.</div>
<div>By Ivan Čukić.</div>


<p style="color: grey;"><i>Updated Oct. 13, 2015, 8:58 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is based on the VDG (Andrew's) mockup.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Activities have more contextual information</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Configuration and activity creation interface is the same as in activities KCM</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Fixed the issue of plasma locking when Qt decides will-I-won't-I (the relayout loop when it decides whether to show a scroll-bar or not)</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It requires the latest KActivities master.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Latest:
<img alt="New shot" src="http://ibin.co/2IwP3j7dcjPe" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Previous:
<img alt="Shot" src="http://ibin.co/2IvS4TSHzgKE" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/activitymanager/ActivityCreationDialog.qml <span style="color: grey">(9317b0e)</span></li>

 <li>desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml <span style="color: grey">(523aba6)</span></li>

 <li>desktoppackage/contents/activitymanager/ActivityItem.qml <span style="color: grey">(526716c)</span></li>

 <li>desktoppackage/contents/activitymanager/ActivityList.qml <span style="color: grey">(e8bf5f0)</span></li>

 <li>desktoppackage/contents/activitymanager/ActivityManager.qml <span style="color: grey">(ff5cdc1)</span></li>

 <li>desktoppackage/contents/activitymanager/ControlButton.qml <span style="color: grey">(1e9854f)</span></li>

 <li>desktoppackage/contents/activitymanager/Heading.qml <span style="color: grey">(be95b9e)</span></li>

 <li>desktoppackage/contents/activitymanager/StoppedActivityItem.qml <span style="color: grey">(c1a417f)</span></li>

 <li>desktoppackage/contents/activitymanager/static.js <span style="color: grey">(0eaab96)</span></li>

 <li>imports/activitymanager/switcherbackend.h <span style="color: grey">(846862e)</span></li>

 <li>imports/activitymanager/switcherbackend.cpp <span style="color: grey">(736fe67)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125626/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>