Review Request 125626: New activity switcher UI

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125626/#review86817
-----------------------------------------------------------



desktoppackage/contents/activitymanager/ActivityItem.qml (line 163)
<https://git.reviewboard.kde.org/r/125626/#comment59716>

    True, leftover from some earlier tries.



desktoppackage/contents/activitymanager/ActivityItem.qml (line 239)
<https://git.reviewboard.kde.org/r/125626/#comment59715>

    Not really, it is meant to show how many documents and applications are open in the activity, or something similar.
    
    I should put it in a comment I guess until that part is implemented.



desktoppackage/contents/activitymanager/StoppedActivityItem.qml (line 45)
<https://git.reviewboard.kde.org/r/125626/#comment59717>

    Double smallSpacing on top and bottom. Yes, it is a bit... but it looks nicer.



imports/activitymanager/switcherbackend.cpp (line 332)
<https://git.reviewboard.kde.org/r/125626/#comment59718>

    I'll open a separate issue for that - replacing this should not really be a part of this patch.



imports/activitymanager/switcherbackend.cpp (line 418)
<https://git.reviewboard.kde.org/r/125626/#comment59719>

    I don't want to have *.* precision. I'd even like to have 'a few minutes ago', 'half an hour ago' (something like the fuzzy clock) instead of having it as precise as it is now, but that might be an overkill.


- Ivan Čukić


On Oct. 13, 2015, 5:32 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125626/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:32 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is based on the VDG (Andrew's) mockup.
> 
> - Activities have more contextual information
> - Configuration and activity creation interface is the same as in activities KCM
> - Fixed the issue of plasma locking when Qt decides will-I-wount-I (the relayout loop when it decides whether to show a scroll-bar or not)
> 
> It requires the latest KActivities master.
> 
> 
> ![Shoot](http://ibin.co/2IvS4TSHzgKE)
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml 523aba6 
>   desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 9317b0e 
>   desktoppackage/contents/activitymanager/ActivityItem.qml 526716c 
>   desktoppackage/contents/activitymanager/ActivityList.qml e8bf5f0 
>   desktoppackage/contents/activitymanager/ActivityManager.qml ff5cdc1 
>   desktoppackage/contents/activitymanager/ControlButton.qml 1e9854f 
>   desktoppackage/contents/activitymanager/Heading.qml be95b9e 
>   desktoppackage/contents/activitymanager/StoppedActivityItem.qml c1a417f 
>   desktoppackage/contents/activitymanager/static.js 0eaab96 
>   imports/activitymanager/switcherbackend.h 846862e 
>   imports/activitymanager/switcherbackend.cpp 736fe67 
> 
> Diff: https://git.reviewboard.kde.org/r/125626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/71373dd7/attachment.html>