Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/#review87844
-----------------------------------------------------------


> clicking on Detailed Memory Information from context menu just does nothing.

can we do more about it? Showing a dialog with "compiled without QtWebkitWidgets, please contact your distribution" or something like this?


config-ksysguard.h.cmake (line 14)
<https://git.reviewboard.kde.org/r/125887/#comment60276>

    suggestion also for future cases: use
        #cmakedefine01 HAVE_FOO
    
    and then in the code it's
        #if HAVE_FOO
        // specific stuf
        #endif
    
    instead of
        #ifdef HAVE_FOO


- Martin Gräßlin


On Oct. 31, 2015, 11:54 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125887/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 11:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> When building without QtWebKitWidgets, the Detailed Memory Information dialog is not working (will not be opened at all).
> This makes plasma-workspace build without QtWebKitWidgets as it requires KSysGuardProcessList from ProcessUI.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 14d32d9 
>   config-ksysguard.h.cmake d95e1f5 
>   processui/CMakeLists.txt 7f87b85 
>   processui/scripting.h e8b1e3b 
>   processui/scripting.cpp adcb354 
> 
> Diff: https://git.reviewboard.kde.org/r/125887/diff/
> 
> 
> Testing
> -------
> 
> Builds, clicking on Detailed Memory Information from context menu just does nothing.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/5f124b75/attachment.html>