Review Request 125886: drkonqi: Drop KF5::WebKit dependency

David Rosca nowrep at gmail.com
Mon Nov 2 09:42:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125886/
-----------------------------------------------------------

(Updated Nov. 2, 2015, 9:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 6aedc9534f76f9fb0d5d9560f81a704bda1e8df7 by David Rosca to branch master.


Repository: plasma-workspace


Description
-------

Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
KWebView is not used to load a page here, it is just used to display HTML with setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are not resolved.
Replacing it with QTextBrowser should provide similar rendering.


Diffs
-----

  CMakeLists.txt 50091ea 
  drkonqi/CMakeLists.txt 339b475 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp b6beea3 

Diff: https://git.reviewboard.kde.org/r/125886/diff/


Testing
-------

Made sure it builds, no idea how to trigger the dialog.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/cb6adc96/attachment.html>


More information about the Plasma-devel mailing list