Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

David Rosca nowrep at gmail.com
Mon Nov 2 10:11:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/
-----------------------------------------------------------

(Updated Nov. 2, 2015, 10:11 a.m.)


Review request for Plasma.


Changes
-------

Changed to #cmakedefine01 + added No QtWebKitWidgets dialog


Repository: libksysguard


Description
-------

When building without QtWebKitWidgets, the Detailed Memory Information dialog is not working (will not be opened at all).
This makes plasma-workspace build without QtWebKitWidgets as it requires KSysGuardProcessList from ProcessUI.


Diffs (updated)
-----

  CMakeLists.txt 14d32d9 
  config-ksysguard.h.cmake d95e1f5 
  processui/CMakeLists.txt 7f87b85 
  processui/scripting.h e8b1e3b 
  processui/scripting.cpp adcb354 

Diff: https://git.reviewboard.kde.org/r/125887/diff/


Testing
-------

Builds, clicking on Detailed Memory Information from context menu just does nothing.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/b4f6e0df/attachment.html>


More information about the Plasma-devel mailing list