Review Request 123926: Unbreak Undo notifications on Plasma delete

[Martin Klapetek]

> On May 28, 2015, 5:52 p.m., Lukáš Tinkl wrote:
> > dataengines/notifications/notificationsengine.cpp, line 157
> > <https://git.reviewboard.kde.org/r/123926/diff/1/?file=378269#file378269line157>
> >
> >     QStringLiteral() ?

Nah, QLatin1String is faster for comparisons (and enough for comparisons).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/#review80932
-----------------------------------------------------------


On May 28, 2015, 5:50 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123926/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 5:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for plasmashell and that broke the undo notifications if you undo twice in a row.
> 
> 
> Diffs
> -----
> 
>   dataengines/notifications/notificationsengine.cpp 509f349 
> 
> Diff: https://git.reviewboard.kde.org/r/123926/diff/
> 
> 
> Testing
> -------
> 
> Now I get two separate Undo notifications.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150528/533ffaaa/attachment.html>