Review Request 123926: Unbreak Undo notifications on Plasma delete

Lukáš Tinkl lukas at kde.org
Thu May 28 15:52:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/#review80932
-----------------------------------------------------------

Ship it!



dataengines/notifications/notificationsengine.cpp (line 157)
<https://git.reviewboard.kde.org/r/123926/#comment55451>

    QStringLiteral() ?


- Lukáš Tinkl


On Kvě. 28, 2015, 5:50 odp., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123926/
> -----------------------------------------------------------
> 
> (Updated Kvě. 28, 2015, 5:50 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for plasmashell and that broke the undo notifications if you undo twice in a row.
> 
> 
> Diffs
> -----
> 
>   dataengines/notifications/notificationsengine.cpp 509f349 
> 
> Diff: https://git.reviewboard.kde.org/r/123926/diff/
> 
> 
> Testing
> -------
> 
> Now I get two separate Undo notifications.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150528/0b19998e/attachment-0001.html>


More information about the Plasma-devel mailing list