<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123926/">https://git.reviewboard.kde.org/r/123926/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 28th, 2015, 5:52 p.m. CEST, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123926/diff/1/?file=378269#file378269line157" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/notifications/notificationsengine.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">uint NotificationsEngine::Notify(const QString &app_name, uint replaces_id,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">157</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_activeNotifications</span><span class="p">.</span><span class="n">values</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">app_name</span> <span class="o">+</span> <span class="n">summary</span><span class="p">)</span> <span class="o">&&</span> <span class="n">app_name</span> <span class="o">!=</span> <span class="n">Q<span class="hl">GuiApplic</span>ati<span class="hl">on</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">applicationDisplayName</span></span><span class="p"><span class="hl">(</span>)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">m_alwaysReplaceAppsList</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">app_name</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">157</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_activeNotifications</span><span class="p">.</span><span class="n">values</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">app_name</span> <span class="o">+</span> <span class="n">summary</span><span class="p">)</span> <span class="o">&&</span> <span class="n">app_name</span> <span class="o">!=</span> <span class="n">Q<span class="hl">L</span>ati<span class="hl">n1String</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Plasma Workspace"</span></span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">m_alwaysReplaceAppsList</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">app_name</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QStringLiteral() ?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nah, QLatin1String is faster for comparisons (and enough for comparisons).</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On May 28th, 2015, 5:50 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 28, 2015, 5:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for plasmashell and that broke the undo notifications if you undo twice in a row.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now I get two separate Undo notifications.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/notifications/notificationsengine.cpp <span style="color: grey">(509f349)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123926/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>