Review Request 123738: Use column major in the taskbar when "Force row settings" is set

[Kåre Särs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123738/
-----------------------------------------------------------

(Updated maj 17, 2015, 8:01 e.m.)


Review request for Plasma and Eike Hein.


Changes
-------

Update the if-statement, rearrange the configure options as requested and apply similar indentation/option-disabling to "Grouping and sorting"

Note: This patch is tested against the system installed plasma 5.3 instalation. It should work with master also but I have not been able to test that as I don't have the build environment up and running (yet).


Repository: plasma-desktop


Description
-------

When we have "Force row settings" and more than one row of items, the items start to jump around and it is had to keep track of where each item is. 

The atached patch changes the flow to TopToBottom, in stead of LeftToRight, when we have a horizontal layout and "Force row settings", and similarly to LeftToRight in vertical layout. (In practice the vertical layout is always one column and this patch has no effect)

Here are two videos that describe the problem
First is the row major where taskbar items jump around:
https://youtu.be/8udr2DJKobw

And the second with a patched taskbar where the items jump around a lot less:
https://youtu.be/bk17gnu1ETo


Diffs (updated)
-----

  applets/taskmanager/package/contents/ui/ConfigGeneral.qml 36dd134 
  applets/taskmanager/package/contents/ui/main.qml 98ba7c3 

Diff: https://git.reviewboard.kde.org/r/123738/diff/


Testing (updated)
-------

I have applied this patch to the system installed plasma 5.3 installation.


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150517/2a7ccaac/attachment.html>