Review Request 123738: Use column major in the taskbar when "Force row settings" is set

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123738/#review80550
-----------------------------------------------------------


Aside from the string issue I think this is fine now. Technically the string won't really work for vertical panels, but as you pointed out the force code is currently not working for vertical anyway (which is a regression). I'll fix this and address making the config UI adapt to plasmoid location after this gets in.


applets/taskmanager/package/contents/ui/ConfigGeneral.qml (line 66)
<https://git.reviewboard.kde.org/r/123738/#comment55225>

    This will literally show "Always arrange tasks in columns of x rows" when maxStripes.value is 1. I don't think i18np will really work for us here, could you go with the string I suggested?


- Eike Hein


On May 17, 2015, 8:01 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123738/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 8:01 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> When we have "Force row settings" and more than one row of items, the items start to jump around and it is had to keep track of where each item is. 
> 
> The atached patch changes the flow to TopToBottom, in stead of LeftToRight, when we have a horizontal layout and "Force row settings", and similarly to LeftToRight in vertical layout. (In practice the vertical layout is always one column and this patch has no effect)
> 
> Here are two videos that describe the problem
> First is the row major where taskbar items jump around:
> https://youtu.be/8udr2DJKobw
> 
> And the second with a patched taskbar where the items jump around a lot less:
> https://youtu.be/bk17gnu1ETo
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ConfigGeneral.qml 36dd134 
>   applets/taskmanager/package/contents/ui/main.qml 98ba7c3 
> 
> Diff: https://git.reviewboard.kde.org/r/123738/diff/
> 
> 
> Testing
> -------
> 
> I have applied this patch to the system installed plasma 5.3 installation.
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150517/96491e22/attachment-0001.html>