Review Request 123738: Use column major in the taskbar when "Force row settings" is set

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123738/#review80309
-----------------------------------------------------------


The implementation is fine (modulo the nitpick) and I'm on board with the goals here, but I don't feel too great about magically changing layout behavior when "Force row settings" is ticked on. Please do the following:

1. Rename the Appearance group box in the config dialog to "Arrangement"
2. Move the tooltip checkbox into "Behavior"
3. Put the "Maximum rows" spinbox as the first item in "Arrangement"
4. Rename the "Force row settings" checkbox to "Always arrange tasks in columns of as many rows" and indent it under the spinbox and enable it when spinbox.value > 1


applets/taskmanager/package/contents/ui/main.qml (line 237)
<https://git.reviewboard.kde.org/r/123738/#comment55102>

    I'd prefer if you write this
    
    if (tasks.vertical) {
        return plasmoid.configuration.forceStripes ? ...
    } else {
        return plasmoid.configuration.forceStripes ? ...
    }


- Eike Hein


On May 13, 2015, 3:45 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123738/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 3:45 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> When we have "Force row settings" and more than one row of items, the items start to jump around and it is had to keep track of where each item is. 
> 
> The atached patch changes the flow to TopToBottom, in stead of LeftToRight, when we have a horizontal layout and "Force row settings", and similarly to LeftToRight in vertical layout. (In practice the vertical layout is always one column and this patch has no effect)
> 
> Here are two videos that describe the problem
> First is the row major where taskbar items jump around:
> https://youtu.be/8udr2DJKobw
> 
> And the second with a patched taskbar where the items jump around a lot less:
> https://youtu.be/bk17gnu1ETo
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/main.qml 98ba7c3 
> 
> Diff: https://git.reviewboard.kde.org/r/123738/diff/
> 
> 
> Testing
> -------
> 
> I'm using this patch on all my installations and tried the vertical layout
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150513/8ba8fb4b/attachment-0001.html>