Review Request 123814: Use KMessageWidget for polkit error

Kai Uwe Broulik kde at privat.broulik.de
Sun May 17 11:37:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123814/
-----------------------------------------------------------

(Updated May 17, 2015, 11:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 9edb5e8041db3080cbebee363a29f699b0a20e3d by Kai Uwe Broulik to branch master.


Repository: polkit-kde-agent-1


Description
-------

The new style for KTitleWidget makes the message get huge. Make it a KMessageWidget, that's also a bit more prominent with its red color.


Diffs
-----

  AuthDialog.ui 20ed6d3 
  AuthDialog.cpp 16ee64d 

Diff: https://git.reviewboard.kde.org/r/123814/diff/


Testing
-------

No widget, enter wrong password, get a widget.


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e68c1609-ea84-4c57-8ecc-6d70ca8bdf0a__errorwidgetbefore.png
After
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/4cf63a1d-f4df-4d02-9cee-dc16fbfbb845__errorwidgetafter.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150517/eab9781d/attachment-0001.html>


More information about the Plasma-devel mailing list