Review Request 123814: Use KMessageWidget for polkit error

David Edmundson david at davidedmundson.co.uk
Sun May 17 11:35:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123814/#review80516
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On May 16, 2015, 4:38 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123814/
> -----------------------------------------------------------
> 
> (Updated May 16, 2015, 4:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: polkit-kde-agent-1
> 
> 
> Description
> -------
> 
> The new style for KTitleWidget makes the message get huge. Make it a KMessageWidget, that's also a bit more prominent with its red color.
> 
> 
> Diffs
> -----
> 
>   AuthDialog.ui 20ed6d3 
>   AuthDialog.cpp 16ee64d 
> 
> Diff: https://git.reviewboard.kde.org/r/123814/diff/
> 
> 
> Testing
> -------
> 
> No widget, enter wrong password, get a widget.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e68c1609-ea84-4c57-8ecc-6d70ca8bdf0a__errorwidgetbefore.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/4cf63a1d-f4df-4d02-9cee-dc16fbfbb845__errorwidgetafter.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150517/6bdf0465/attachment.html>


More information about the Plasma-devel mailing list