Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

Yoann Laissus yoann.laissus at gmail.com
Sat May 16 17:13:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123815/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

The panel configuration width is defined to a fixed value when it's vertical.
In English, it's not a problem because strings are very compacts. But for example, in French, some strings get too big for the buttons.

The width is now computed dynamically from the button layout.
I'm really not a QML expert, please let me know if there is a better way to achieve that.


Diffs
-----

  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd 

Diff: https://git.reviewboard.kde.org/r/123815/diff/


Testing
-------

Tested in all screen edges.


File Attachments
----------------

Truncated text
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg
After the fix
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg


Thanks,

Yoann Laissus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150516/9565d912/attachment.html>


More information about the Plasma-devel mailing list