Review Request 123814: Use KMessageWidget for polkit error
Kai Uwe Broulik
kde at privat.broulik.de
Sat May 16 16:38:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123814/
-----------------------------------------------------------
Review request for Plasma.
Repository: polkit-kde-agent-1
Description
-------
The new style for KTitleWidget makes the message get huge. Make it a KMessageWidget, that's also a bit more prominent with its red color.
Diffs
-----
AuthDialog.ui 20ed6d3
AuthDialog.cpp 16ee64d
Diff: https://git.reviewboard.kde.org/r/123814/diff/
Testing
-------
No widget, enter wrong password, get a widget.
File Attachments
----------------
Before
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e68c1609-ea84-4c57-8ecc-6d70ca8bdf0a__errorwidgetbefore.png
After
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/4cf63a1d-f4df-4d02-9cee-dc16fbfbb845__errorwidgetafter.png
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150516/30b9a912/attachment.html>
More information about the Plasma-devel
mailing list