Review Request 124112: Implement drag and drop for Trash applet

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124112/
-----------------------------------------------------------

(Updated Juni 17, 2015, 4:24 nachm.)


Review request for Plasma.


Changes
-------

Only accept local file drops, filter out non-locals and only highlight when drag is acceptable. There's no way to "reject" a drop.


Bugs: 348378
    https://bugs.kde.org/show_bug.cgi?id=348378


Repository: plasma-desktop


Description
-------

This allows to drag files onto the trash applet to trash them.
Also, the code is cleaned up a bit and it is given a sensible minimum size (so the label always fits) as well as the query dialog has been replaced by the standard KIO dialog.


Diffs (updated)
-----

  applets/trash/package/contents/ui/main.qml 7715439 
  applets/trash/plugin/CMakeLists.txt 9012e66 
  applets/trash/plugin/trash.h PRE-CREATION 
  applets/trash/plugin/trash.cpp PRE-CREATION 
  applets/trash/plugin/trashplugin.cpp 7e866a9 

Diff: https://git.reviewboard.kde.org/r/124112/diff/


Testing
-------

Trashed one or multiple files on both desktop and panel.
When I dismiss the message box, however, Plasma will create an applet for the file dragged. How can I tell it I accepted the drop? Also, it crashes in Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times after dismissing the dialog.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150617/bc311d01/attachment.html>