Review Request 124112: Implement drag and drop for Trash applet

[Kai Uwe Broulik]

> On Juni 17, 2015, 3:51 nachm., Marco Martin wrote:
> > looks good.
> > I wonder if should be ckecked also that the urls are actual filesystem urls or if is fine to just blindlt trash everything thrown at it since if it's not a filesystem one should fail
> 
> Sebastian Kügler wrote:
>     I think even isLocalFile() and isWritable() (or somesuch). Otherwise, the Trash item can't be restored. Also, moving a remote file to local trash doesn't make sense.
> 
> Marco Martin wrote:
>     so the little plugin should have a bool canBeThrashed(QUrl) and QList<QUrl> trashableUrls(QList<QUrl>) that woud filter out the invalid ones

How od I check for writable? KIO something? QFile(foo.toLocalFile()).isWritable() didn't work because that one only checks the OpenMode flags for writing.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124112/#review81527
-----------------------------------------------------------


On Juni 16, 2015, 6:32 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124112/
> -----------------------------------------------------------
> 
> (Updated Juni 16, 2015, 6:32 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348378
>     https://bugs.kde.org/show_bug.cgi?id=348378
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This allows to drag files onto the trash applet to trash them.
> Also, the code is cleaned up a bit and it is given a sensible minimum size (so the label always fits) as well as the query dialog has been replaced by the standard KIO dialog.
> 
> 
> Diffs
> -----
> 
>   applets/trash/package/contents/ui/main.qml 7715439 
>   applets/trash/plugin/CMakeLists.txt 9012e66 
>   applets/trash/plugin/trash.h PRE-CREATION 
>   applets/trash/plugin/trash.cpp PRE-CREATION 
>   applets/trash/plugin/trashplugin.cpp 7e866a9 
> 
> Diff: https://git.reviewboard.kde.org/r/124112/diff/
> 
> 
> Testing
> -------
> 
> Trashed one or multiple files on both desktop and panel.
> When I dismiss the message box, however, Plasma will create an applet for the file dragged. How can I tell it I accepted the drop? Also, it crashes in Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times after dismissing the dialog.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150617/a873a541/attachment.html>