Review Request 124112: Implement drag and drop for Trash applet

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124112/#review81537
-----------------------------------------------------------


QFile::isWritable() is confusing, it falls back to QIODevice::isWritable(), which tells you whether the object is /opened for writing/, not if you're allowed to write. The right API to use here is QFileInfo::isWritable(), which should do the right thing.


applets/trash/package/contents/ui/main.qml (line 116)
<https://git.reviewboard.kde.org/r/124112/#comment55887>

    minor one, but please add spaces around the ==



applets/trash/package/contents/ui/main.qml (line 125)
<https://git.reviewboard.kde.org/r/124112/#comment55888>

    spaces around comparison ops



applets/trash/plugin/trashplugin.cpp (line 30)
<https://git.reviewboard.kde.org/r/124112/#comment55889>

    I think we still want to delete this one *somewhere*?


ou a

- Sebastian Kügler


On June 17, 2015, 4:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124112/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 4:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348378
>     https://bugs.kde.org/show_bug.cgi?id=348378
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This allows to drag files onto the trash applet to trash them.
> Also, the code is cleaned up a bit and it is given a sensible minimum size (so the label always fits) as well as the query dialog has been replaced by the standard KIO dialog.
> 
> 
> Diffs
> -----
> 
>   applets/trash/package/contents/ui/main.qml 7715439 
>   applets/trash/plugin/CMakeLists.txt 9012e66 
>   applets/trash/plugin/trash.h PRE-CREATION 
>   applets/trash/plugin/trash.cpp PRE-CREATION 
>   applets/trash/plugin/trashplugin.cpp 7e866a9 
> 
> Diff: https://git.reviewboard.kde.org/r/124112/diff/
> 
> 
> Testing
> -------
> 
> Trashed one or multiple files on both desktop and panel.
> When I dismiss the message box, however, Plasma will create an applet for the file dragged. How can I tell it I accepted the drop? Also, it crashes in Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times after dismissing the dialog.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150617/7884c40c/attachment.html>