AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

[Leslie Zhai]

well done! I will follow your code ;P

On 2015年07月31日 14:04, Pier Luigi Fiorini wrote:
> 2015-07-29 11:02 GMT+02:00 David Edmundson <david at davidedmundson.co.uk>:
>> Hey, sorry for not replying.
>>
>> 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't
>> have to rush.
>>
>> In general, I like it, I have some comments.
>>
>> I'm a bit concerned by the blocking calls in AccountsService here:
>> https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107
>>
>> That has the potential to lock up the entire plasma workspace session; which
>> obviously isn't ideal.
>> Blocking calls are a problem if we can't rely on the remote service /always/
>> behaving.
> This is being fixed now. cacheUser() is using the pending call watcher
> and emit a signal userCached() when it's done.
> Probably more methods need a watcher though.
>
> BTW The library has now unit tests and CI.
>
> In case someone is interested, here's a link to the API review task:
> https://github.com/hawaii-desktop/qtaccountsservice/issues/7
>

-- 
Regards,
Leslie Zhai