AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

[David Edmundson]

On Wed, Jul 29, 2015 at 11:25 AM, Leslie Zhai <xiang.zhai at i-soft.com.cn>
wrote:

>
>
> On 07/29/2015 05:02 PM, David Edmundson wrote:
>
>> Hey, sorry for not replying.
>>
> Never mind, thanks for your reply ;P
>
>
>> 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't
>> have to rush.
>>
> OK.
>
>
>> In general, I like it, I have some comments.
>>
>> I'm a bit concerned by the blocking calls in AccountsService here:
>>
>> https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107
>>
>> That has the potential to lock up the entire plasma workspace session;
>> which obviously isn't ideal.
>> Blocking calls are a problem if we can't rely on the remote service
>> /always/ behaving.
>>
> OK, I will fix it
> https://github.com/hawaii-desktop/qtaccountsservice/issues/9
>
>
>> --
>>
>> In here:
>> http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hp=b500ba44c2b483d7372ca46840152c90ef5f798c&hb=1f308546910b1e3e63542bb1982778755e8ff99d&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp
>>
>> we're using QtAccounts for the icon, but KUser for the name. That's a bit
>> weird.
>>
> I will take replace all KUser to QtAccouts ASAP.
>
>
>> --
>>
>> What's this for:
>>
>> http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=a4888cef5415d09e36f594080e4f1d1103b896ec&hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hb=58091b95fae55fcc96e95a28599df05130a64bb6&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp
>>
>> AccountsService will also search ~/.face.icon, so I can't imagine this
>> doing anything.
>>
>> ---
>>
>> We have some code in KDeclarative that returns a user, wrapping kuser. I
>> don't want to have code in our lib that does one thing, and have our shell
>> code doing another.
>>
> So, do you agree to wrapping AccountsService ;-)
>
>
If we can.
What's going to be hard is trying to plug an async API into an existing
synchronous API; that's often difficult.
And because kuser is in frameworks, we can't break ABI at all.



>
>>
>> David
>>
>
> --
> Regards,
> Leslie Zhai
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150729/1eb1bfc6/attachment.html>