<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 29, 2015 at 11:25 AM, Leslie Zhai <span dir="ltr"><<a href="mailto:xiang.zhai@i-soft.com.cn" target="_blank">xiang.zhai@i-soft.com.cn</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 07/29/2015 05:02 PM, David Edmundson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey, sorry for not replying.<br>
</blockquote></span>
Never mind, thanks for your reply ;P<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
5.4 is being frozen soon, so lets consider this 5.5 material, so we don't have to rush.<br>
</blockquote></span>
OK.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
In general, I like it, I have some comments.<br>
<br>
I'm a bit concerned by the blocking calls in AccountsService here:<br>
<a href="https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107" rel="noreferrer" target="_blank">https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107</a><br>
<br>
That has the potential to lock up the entire plasma workspace session; which obviously isn't ideal.<br>
Blocking calls are a problem if we can't rely on the remote service /always/ behaving.<br>
</blockquote></span>
OK, I will fix it <a href="https://github.com/hawaii-desktop/qtaccountsservice/issues/9" rel="noreferrer" target="_blank">https://github.com/hawaii-desktop/qtaccountsservice/issues/9</a><span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
--<br>
<br>
In here: <a href="http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hp=b500ba44c2b483d7372ca46840152c90ef5f798c&hb=1f308546910b1e3e63542bb1982778755e8ff99d&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp" rel="noreferrer" target="_blank">http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hp=b500ba44c2b483d7372ca46840152c90ef5f798c&hb=1f308546910b1e3e63542bb1982778755e8ff99d&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp</a><br>
<br>
we're using QtAccounts for the icon, but KUser for the name. That's a bit weird.<br>
</blockquote></span>
I will take replace all KUser to QtAccouts ASAP.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
--<br>
<br>
What's this for:<br>
<a href="http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=a4888cef5415d09e36f594080e4f1d1103b896ec&hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hb=58091b95fae55fcc96e95a28599df05130a64bb6&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp" rel="noreferrer" target="_blank">http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=a4888cef5415d09e36f594080e4f1d1103b896ec&hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hb=58091b95fae55fcc96e95a28599df05130a64bb6&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp</a><br>
<br>
AccountsService will also search ~/.face.icon, so I can't imagine this doing anything.<br>
<br>
---<br>
<br>
We have some code in KDeclarative that returns a user, wrapping kuser. I don't want to have code in our lib that does one thing, and have our shell code doing another.<br>
</blockquote></span>
So, do you agree to wrapping AccountsService ;-)<br>
<br></blockquote><div><br></div><div>If we can.<br>What's going to be hard is trying to plug an async API into an existing synchronous API; that's often difficult.<br></div><div>And because kuser is in frameworks, we can't break ABI at all.<br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
David<span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
Regards,<br>
Leslie Zhai<br>
<br>
<br>
<br>
</font></span></blockquote></div><br></div></div>