Review Request 121945: Use i18np for plural units in the jobs applet

Martin Klapetek martin.klapetek at gmail.com
Mon Jan 12 14:04:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121945/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 3:04 p.m.)


Review request for Plasma.


Changes
-------

Use i18ncp properly

Btw. how many oks from i18n are needed? There was just one but no objections, so I guess I'll just ship this...


Bugs: 342640
    https://bugs.kde.org/show_bug.cgi?id=342640


Repository: plasma-workspace


Description
-------

Yesterday came a bug report about using non-plural i18n for the jobs unit. We need to use plural so that some locales may provide different variations for different numbers.

For example Czech has
1 soubor
2 soubory
...
5 soubor?
...

Unfortunately this came with the string freeze for 5.2, but I think this would be nice to have for 5.2. I'll ask for an exception (and review).


Diffs (updated)
-----

  applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 

Diff: https://git.reviewboard.kde.org/r/121945/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150112/32aaa0c5/attachment.html>


More information about the Plasma-devel mailing list