Review Request 121945: Use i18np for plural units in the jobs applet

[Martin Klapetek]

> On Jan. 10, 2015, 11:23 p.m., Albert Astals Cid wrote:
> > applets/notifications/package/contents/ui/JobDetailsItem.qml, line 61
> > <https://git.reviewboard.kde.org/r/121945/diff/1/?file=339299#file339299line61>
> >
> >     What about something like
> >     
> >     return i18np("%2 of 1 file", "%2 of %1 files", total, processed);
> >     
> >     and the same for dirs?

Fwiw I didn't really think about that case because when there's just one file it's not displayed at all as it's clear from the context that only one file is being copied and also this saves some (unhelpful) text in a small area already full of text. But I sure, I'll change it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121945/#review73715
-----------------------------------------------------------


On Jan. 9, 2015, 2:55 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121945/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 2:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 342640
>     https://bugs.kde.org/show_bug.cgi?id=342640
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Yesterday came a bug report about using non-plural i18n for the jobs unit. We need to use plural so that some locales may provide different variations for different numbers.
> 
> For example Czech has
> 1 soubor
> 2 soubory
> ...
> 5 soubor?
> ...
> 
> Unfortunately this came with the string freeze for 5.2, but I think this would be nice to have for 5.2. I'll ask for an exception (and review).
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 
> 
> Diff: https://git.reviewboard.kde.org/r/121945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150112/c2fbad74/attachment.html>