Review Request 121945: Use i18np for plural units in the jobs applet

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121945/#review73890
-----------------------------------------------------------



applets/notifications/package/contents/ui/JobDetailsItem.qml
<https://git.reviewboard.kde.org/r/121945/#comment51368>

    This is wrong, the plural form is decided by the first integer-valued argument so please use the form I suggested
    
    %2 of %1 files"


- Albert Astals Cid


On gen. 12, 2015, 2:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121945/
> -----------------------------------------------------------
> 
> (Updated gen. 12, 2015, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 342640
>     https://bugs.kde.org/show_bug.cgi?id=342640
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Yesterday came a bug report about using non-plural i18n for the jobs unit. We need to use plural so that some locales may provide different variations for different numbers.
> 
> For example Czech has
> 1 soubor
> 2 soubory
> ...
> 5 soubor?
> ...
> 
> Unfortunately this came with the string freeze for 5.2, but I think this would be nice to have for 5.2. I'll ask for an exception (and review).
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 
> 
> Diff: https://git.reviewboard.kde.org/r/121945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150112/7f8812d9/attachment.html>