Review Request 122660: Breeze Decoration Redesign

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122660/#review76378
-----------------------------------------------------------


"Preinstalled colours schemes to ensure consistent colouring" 
that is a regression with respect to exiting code. Its a no go. Please include.

"Updated the behaviour of the resize grip - fixed bug for fullscreen"
Can you post a bug report related to the bug ? There was indeed an issue with size grip and fullscreen window, but this was fixed, as far as I know. See https://bugs.kde.org/show_bug.cgi?id=343988 and commit therein

"Redesigned buttons and tweaked the titlebar slightly."
Can you post screenshots ? Were these changes discussed in the Visual Design Group forum ? (https://forum.kde.org/viewforum.php?f=285)

"Font weight will now affect the boldness of icons in buttons"
Same question. 
No other element in the widget style has this behavior (icons, frame sizes, etc.), so I'd like to know the rationale behind it and get this discussed.

I have not tested the changes yet, but will do asap

- Hugo Pereira Da Costa


On Feb. 21, 2015, 11:45 a.m., Ken Vermette wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122660/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 11:45 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Overhaul of the Breeze Window decoration drawing code; 
>  - Redesigned buttons and tweaked the titlebar slightly. 
>  - Updated the behaviour of the resize grip - fixed bug for fullscreen
>  - Font weight will now affect the boldness of icons in buttons
> 
> Note; Buttons are not animated yet in this variant.
> 
> 
> Diffs
> -----
> 
>   kdecoration/breezebutton.cpp 5ac0cfe 
>   kdecoration/breezedecoration.h 9eb6c65 
>   kdecoration/breezedecoration.cpp b474a8b 
>   kdecoration/breezebutton.h c43959a 
> 
> Diff: https://git.reviewboard.kde.org/r/122660/diff/
> 
> 
> Testing
> -------
> 
> - Preinstalled colours schemes to ensure consistent colouring
>  - Viewed various button sizes
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150221/857a2856/attachment.html>