<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122660/">https://git.reviewboard.kde.org/r/122660/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Preinstalled colours schemes to ensure consistent colouring"
that is a regression with respect to exiting code. Its a no go. Please include.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Updated the behaviour of the resize grip - fixed bug for fullscreen"
Can you post a bug report related to the bug ? There was indeed an issue with size grip and fullscreen window, but this was fixed, as far as I know. See https://bugs.kde.org/show_bug.cgi?id=343988 and commit therein</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Redesigned buttons and tweaked the titlebar slightly."
Can you post screenshots ? Were these changes discussed in the Visual Design Group forum ? (https://forum.kde.org/viewforum.php?f=285)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Font weight will now affect the boldness of icons in buttons"
Same question.
No other element in the widget style has this behavior (icons, frame sizes, etc.), so I'd like to know the rationale behind it and get this discussed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have not tested the changes yet, but will do asap</p></pre>
<br />
<p>- Hugo Pereira Da Costa</p>
<br />
<p>On February 21st, 2015, 11:45 a.m. UTC, Ken Vermette wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By Ken Vermette.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2015, 11:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Overhaul of the Breeze Window decoration drawing code;
- Redesigned buttons and tweaked the titlebar slightly.
- Updated the behaviour of the resize grip - fixed bug for fullscreen
- Font weight will now affect the boldness of icons in buttons</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note; Buttons are not animated yet in this variant.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Preinstalled colours schemes to ensure consistent colouring</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Viewed various button sizes</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecoration/breezebutton.cpp <span style="color: grey">(5ac0cfe)</span></li>
<li>kdecoration/breezedecoration.h <span style="color: grey">(9eb6c65)</span></li>
<li>kdecoration/breezedecoration.cpp <span style="color: grey">(b474a8b)</span></li>
<li>kdecoration/breezebutton.h <span style="color: grey">(c43959a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122660/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>