Review Request 122660: Breeze Decoration Redesign

[Ken Vermette]

> On Feb. 21, 2015, 1:44 p.m., Hugo Pereira Da Costa wrote:
> > "Preinstalled colours schemes to ensure consistent colouring" 
> > that is a regression with respect to exiting code. Its a no go. Please include.
> > 
> > "Updated the behaviour of the resize grip - fixed bug for fullscreen"
> > Can you post a bug report related to the bug ? There was indeed an issue with size grip and fullscreen window, but this was fixed, as far as I know. See https://bugs.kde.org/show_bug.cgi?id=343988 and commit therein
> > 
> > "Redesigned buttons and tweaked the titlebar slightly."
> > Can you post screenshots ? Were these changes discussed in the Visual Design Group forum ? (https://forum.kde.org/viewforum.php?f=285)
> > 
> > "Font weight will now affect the boldness of icons in buttons"
> > Same question. 
> > No other element in the widget style has this behavior (icons, frame sizes, etc.), so I'd like to know the rationale behind it and get this discussed.
> > 
> > I have not tested the changes yet, but will do asap

"that is a regression with respect to exiting code. Its a no go. Please include."
Sorry, I should have said "tested with preinstalled colour schemes"; I was just checking to ensure colours were sane for themes; make sure the buttons didn't turn neon-pink when using obsidian or anything like that.

"There was indeed an issue with size grip and fullscreen window ..."
I re-wrote the grip behaviour with the input of Jens (another VDG member); I wasn't specifically aiming to do it with the change to the grip display code, but I was aware that it would be fixed in my build. The new behaviour should hide the grip on maximised windows and inactive windows; on maximised windows the grip is pointless, and on inactive windows the grip is not obvious, but still covers scrollbars or status items...

"Can you post screenshots ?"
Of course; they're included now.

"Were these changes discussed in the Visual Design Group forum ?"
Not on the forum, no. I did refer to Jens during the sprint, and other members of the VDG have responded positivly to my screenshot on G+. This is also an initial version, and assuming it flies I'll be updating based on feedback accordingly. The design is also evolutionary anyway.

"No other element in the widget style has this behavior (icons, frame sizes, etc.), so I'd like to know the rationale behind it and get this discussed."
I was going to add a config option but if I had of done this, but I chose to use the font width to avoid overburdening the settings dialog with tweaker stuff - it's less than a 0.7px difference.

I'd be perfectly fine removing the feature; when first starting I did not know there was a float variant of setWidth - so I could not get the line to a happy medium; now that I have it at a 'good' width it was kept simply because it could 'follow along' with the font easily. The edit is <1 line.


- Ken


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122660/#review76378
-----------------------------------------------------------


On Feb. 21, 2015, 2:53 p.m., Ken Vermette wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122660/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 2:53 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Overhaul of the Breeze Window decoration drawing code; 
>  - Redesigned buttons and tweaked the titlebar slightly. 
>  - Updated the behaviour of the resize grip - fixed bug for fullscreen
>  - Font weight will now affect the boldness of icons in buttons
> 
> Note; Buttons are not animated yet in this variant.
> 
> 
> Diffs
> -----
> 
>   kdecoration/breezebutton.cpp 5ac0cfe 
>   kdecoration/breezedecoration.h 9eb6c65 
>   kdecoration/breezedecoration.cpp b474a8b 
>   kdecoration/breezebutton.h c43959a 
> 
> Diff: https://git.reviewboard.kde.org/r/122660/diff/
> 
> 
> Testing
> -------
> 
> - Tried out preinstalled colours schemes to ensure consistent colouring
>  - Viewed various button sizes
> 
> 
> File Attachments
> ----------------
> 
> Updated Decos
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/21/66f8d3d8-5852-4b79-b211-339cbc7bf712__newdecos.png
> Full Windows
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/21/20580b13-3bb1-4020-9ddf-8d1253184a45__snapshot1.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150221/428eff80/attachment.html>