Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled
David Edmundson
david at davidedmundson.co.uk
Wed Dec 9 22:09:43 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126296/#review89283
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Dec. 9, 2015, 10:03 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126296/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 10:03 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> We were checking for Composite at compile-time but not at runtime causing a crash.
>
> There was a bug about it but I can't find it.
>
>
> Diffs
> -----
>
> src/declarativeimports/core/windowthumbnail.h 63d919f
> src/declarativeimports/core/windowthumbnail.cpp 2b09657
>
> Diff: https://git.reviewboard.kde.org/r/126296/diff/
>
>
> Testing
> -------
>
> With Composite -> proper window thumbnail
> Without Composite -> window icon (instead of crash)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151209/c871126e/attachment.html>
More information about the Plasma-devel
mailing list