Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126296/#review89293
-----------------------------------------------------------

Ship it!


How is it possible to have damage enabled, but composite disabled?

- Martin Gräßlin


On Dec. 9, 2015, 11:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126296/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 11:03 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We were checking for Composite at compile-time but not at runtime causing a crash.
> 
> There was a bug about it but I can't find it.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.h 63d919f 
>   src/declarativeimports/core/windowthumbnail.cpp 2b09657 
> 
> Diff: https://git.reviewboard.kde.org/r/126296/diff/
> 
> 
> Testing
> -------
> 
> With Composite -> proper window thumbnail
> Without Composite -> window icon (instead of crash)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151210/959245f9/attachment.html>