Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled

Kai Uwe Broulik kde at privat.broulik.de
Wed Dec 9 22:03:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126296/
-----------------------------------------------------------

Review request for Plasma and Martin Gräßlin.


Repository: plasma-framework


Description
-------

We were checking for Composite at compile-time but not at runtime causing a crash.

There was a bug about it but I can't find it.


Diffs
-----

  src/declarativeimports/core/windowthumbnail.h 63d919f 
  src/declarativeimports/core/windowthumbnail.cpp 2b09657 

Diff: https://git.reviewboard.kde.org/r/126296/diff/


Testing
-------

With Composite -> proper window thumbnail
Without Composite -> window icon (instead of crash)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151209/9580a2ac/attachment.html>


More information about the Plasma-devel mailing list