Review Request 124702: Set component display name for all actions

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124702/#review83721
-----------------------------------------------------------


As the review is for master: please remember that this must go intp 5.4!

And thanks for fixing it, I'll do now the same for all KWin Effects KCMs :-(

- Martin Gräßlin


On Aug. 11, 2015, 10:56 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124702/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 10:56 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642).
> 
> 
> Diffs
> -----
> 
>   kcms/keys/kglobalshortcutseditor.cpp 553b10d 
> 
> Diff: https://git.reviewboard.kde.org/r/124702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150812/b92f65b4/attachment.html>