Review Request 124702: Set component display name for all actions

Jan Grulich jgrulich at redhat.com
Wed Aug 12 07:09:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124702/
-----------------------------------------------------------

(Updated Aug. 12, 2015, 7:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
-------

Submitted with commit f22611c6304221d0244fe0114720accbfc0ec2c9 by Jan Grulich to branch master.


Repository: plasma-desktop


Description
-------

Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642).


Diffs
-----

  kcms/keys/kglobalshortcutseditor.cpp 553b10d 

Diff: https://git.reviewboard.kde.org/r/124702/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150812/200b9d31/attachment.html>


More information about the Plasma-devel mailing list