Review Request 124702: Set component display name for all actions
David Edmundson
david at davidedmundson.co.uk
Tue Aug 11 21:03:07 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124702/#review83718
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Aug. 11, 2015, 8:56 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124702/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 8:56 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642).
>
>
> Diffs
> -----
>
> kcms/keys/kglobalshortcutseditor.cpp 553b10d
>
> Diff: https://git.reviewboard.kde.org/r/124702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150811/5fe6cb32/attachment-0001.html>
More information about the Plasma-devel
mailing list