Breeze dark theme white edge outlines

[Andrew Lake]

Thanks for the feedback. Given the collection of responses so far, I'll go
ahead and leave the white outlines as they are.

Regarding duplication of svgs. Yes, the changes I prepared had separate
panel-background, dialog and tooltip svgs specifically for the dark theme.
The main reason is that reflective properties of the edge of the material
changes with color - brighter colors reflect more light, darker colors
reflect less. So where as the Cardboard Grey of the normal Breeze theme
needed a much brighter outline to better represent the quality of the edge,
the dark grey of the breeze dark theme would need a much less bright
outline. The current white outlines that we've grown to like are a happy
accident of the much brighter outline needed for the normal theme. Now,
we'll just say that those outlines are intentional. ;-)

In any event, I think there may be only so much complexity that's worth it
to avoid duplication of svgs. Beyond a certain point a theme of a different
color is, in the end, just a different theme. And these themes are a couple
of drunken grizzly bears to put together as is. :-)

Thanks much for the feedback!
Andrew
[back to visual bug hunting]

On Thu, Oct 2, 2014 at 2:25 AM, Marco Martin <notmart at gmail.com> wrote:

> On Wednesday 01 October 2014 16:21:03 Andrew Lake wrote:
> > For anyone using the breeze dark theme, I've been meaning for a while to
> > make some adjustments so that the edges aren't quite so pronounced and
> high
> > contrast. It looks this way because it's currently using the same svgs
> (and
> > edge highlights) from the normal breeze theme svgs.
> >
> > I have changes ready to push to reduce that high contrast edge outline,
> but
> > I wanted to check to see if there was anyone that was particularly wedded
> > to the those white outlines before I do. I'd do up a screen shot but just
> > imagine those bright white outlines turned all the way down.
> >
> > Holler if anyone has any objections. :-)
>
> does the change involve duplicating the svgs?
>
> I quite like them as well, also i prefer duplication of images to be as
> little
> as possible (just yesterday i fixed some graphics glitches exactly in that,
> means next time work gets to be done double of the times)
>
> I am not that opposed to it, but if it has to be done i would prefer a way
> that doesn't duplicate svgs (that should be possible)
>
> --
> Marco Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141002/46d17861/attachment.html>