Review Request 121121: Remove all kdelibs4support from polkit-agent

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121121/
-----------------------------------------------------------

(Updated Nov. 16, 2014, 1:16 p.m.)


Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.


Changes
-------

I took screenshots of normal and --reverse with the current code. It seems to be correct, as not only is the text reversed but the button is too. So the arrows still point towards the inside of the dialog to open.

Given the text is for styling not actual words, I don't think it should be added to the string. 

If the screenshots don't convince you, I'll change it :)


Repository: polkit-kde-agent-1


Description
-------

Remove all kdelibs4support from polkit-agent


Diffs
-----

  AuthDialog.h eaebbd2 
  AuthDialog.cpp b76d91e 
  AuthDialog.ui e4da0f9 
  CMakeLists.txt 482fc57 
  main.cpp f8f97b8 
  policykitkde.h 85ce6b2 
  policykitkde.cpp a25cb4f 
  policykitlistener.h 538381f 
  policykitlistener.cpp bab7fdf 

Diff: https://git.reviewboard.kde.org/r/121121/diff/


Testing
-------

Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once.


File Attachments (updated)
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/1bb7a716-e855-4ad3-9c36-498077ee016b__polkit_normal.png
screenshot --reverse
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/0e03dc82-a81f-4192-81c7-f6376d545681__polkit_reverse.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141116/66394320/attachment.html>