<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121121/">https://git.reviewboard.kde.org/r/121121/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2014, 1:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I took screenshots of normal and --reverse with the current code. It seems to be correct, as not only is the text reversed but the button is too. So the arrows still point towards the inside of the dialog to open.
Given the text is for styling not actual words, I don't think it should be added to the string.
If the screenshots don't convince you, I'll change it :)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
polkit-kde-agent-1
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove all kdelibs4support from polkit-agent</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>AuthDialog.h <span style="color: grey">(eaebbd2)</span></li>
<li>AuthDialog.cpp <span style="color: grey">(b76d91e)</span></li>
<li>AuthDialog.ui <span style="color: grey">(e4da0f9)</span></li>
<li>CMakeLists.txt <span style="color: grey">(482fc57)</span></li>
<li>main.cpp <span style="color: grey">(f8f97b8)</span></li>
<li>policykitkde.h <span style="color: grey">(85ce6b2)</span></li>
<li>policykitkde.cpp <span style="color: grey">(a25cb4f)</span></li>
<li>policykitlistener.h <span style="color: grey">(538381f)</span></li>
<li>policykitlistener.cpp <span style="color: grey">(bab7fdf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121121/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/1bb7a716-e855-4ad3-9c36-498077ee016b__polkit_normal.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/0e03dc82-a81f-4192-81c7-f6376d545681__polkit_reverse.png">screenshot --reverse</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>