Review Request 121121: Remove all kdelibs4support from polkit-agent

[Lukáš Tinkl]

> On Lis. 14, 2014, 6:27 odp., Martin Klapetek wrote:
> > AuthDialog.cpp, lines 75-76
> > <https://git.reviewboard.kde.org/r/121121/diff/1/?file=328465#file328465line75>
> >
> >     Shouldn't this be one i18n("Details >>") to avoid string puzzles?
> >     
> >     Would require another "Details <<" though, but that's necessary for RTL languages anyway (no?)
> 
> David Edmundson wrote:
>     KDialog does it this way.
> 
> Martin Klapetek wrote:
>     That doesn't make it correct.
>     
>     http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html#good_text

Include it in the string, I fancy RTL languages might want to put it on the left side


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121121/#review70376
-----------------------------------------------------------


On Lis. 14, 2014, 6:08 odp., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121121/
> -----------------------------------------------------------
> 
> (Updated Lis. 14, 2014, 6:08 odp.)
> 
> 
> Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.
> 
> 
> Repository: polkit-kde-agent-1
> 
> 
> Description
> -------
> 
> Remove all kdelibs4support from polkit-agent
> 
> 
> Diffs
> -----
> 
>   AuthDialog.h eaebbd2 
>   AuthDialog.cpp b76d91e 
>   AuthDialog.ui e4da0f9 
>   CMakeLists.txt 482fc57 
>   main.cpp f8f97b8 
>   policykitkde.h 85ce6b2 
>   policykitkde.cpp a25cb4f 
>   policykitlistener.h 538381f 
>   policykitlistener.cpp bab7fdf 
> 
> Diff: https://git.reviewboard.kde.org/r/121121/diff/
> 
> 
> Testing
> -------
> 
> Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141116/48cbf209/attachment.html>