Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

David Edmundson david at davidedmundson.co.uk
Tue May 27 09:25:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/
-----------------------------------------------------------

(Updated May 27, 2014, 9:25 a.m.)


Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer.


Changes
-------

Added screenshot (after)

For before see https://git.reviewboard.kde.org/r/118273/


Repository: oxygen


Description
-------


PM_DefaultLayoutSpacing is deprecated and replaced by both
PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.

Qt Layouts now query for these, not the default spacing.

See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum

There are some other deprecated enums, which are mostly not a problem.


Diffs
-----

  kstyle/oxygenstyle.cpp 8bcb79a 

Diff: https://git.reviewboard.kde.org/r/118337/diff/


Testing
-------

Spacing between labels and controls is now restored o/


File Attachments (updated)
----------------

compositing_kcm
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/a9d5e294/attachment.html>


More information about the Plasma-devel mailing list