Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
David Edmundson
david at davidedmundson.co.uk
Tue May 27 09:25:31 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58545
-----------------------------------------------------------
File Attachment: compositing_kcm - bustle1.png
<https://git.reviewboard.kde.org//r/118337/#fcomment221>
This is still an issue, but one thing at a time.
- David Edmundson
On May 27, 2014, 9:25 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:25 a.m.)
>
>
> Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer.
>
>
> Repository: oxygen
>
>
> Description
> -------
>
>
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
>
> Qt Layouts now query for these, not the default spacing.
>
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
>
> There are some other deprecated enums, which are mostly not a problem.
>
>
> Diffs
> -----
>
> kstyle/oxygenstyle.cpp 8bcb79a
>
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
>
>
> Testing
> -------
>
> Spacing between labels and controls is now restored o/
>
>
> File Attachments
> ----------------
>
> compositing_kcm
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/ad88325b/attachment.html>
More information about the Plasma-devel
mailing list