Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58542
-----------------------------------------------------------


Could you attach a screenshot of the Compositing KCM with the patch applied so we could see whether all layout glitches have been fixed and add Andrew Lake to the review request? That would be great, thanks!

- Thomas Pfeiffer


On May 26, 2014, 11:19 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 11:19 p.m.)
> 
> 
> Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -----
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> -------
> 
> Spacing between labels and controls is now restored o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/b4d8ab58/attachment.html>