Review Request 116024: Port IconItem to native QSGTexture

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/#review57872
-----------------------------------------------------------


I really like the approach!


src/declarativeimports/core/CMakeLists.txt
<https://git.reviewboard.kde.org/r/116024/#comment40270>

    why do you link against Qt5::OpenGL and find it? OpenGL is part of Gui



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40275>

    I normally prefix the varying with v_
    
    e.g.
    varying highp vec2 v_coord



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40276>

    similarily I prefix uniforms with u_
    e.g.
    uniform sampler2D u_src



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40271>

    I'd always activate the GL_TEXTURE0 texture target after setting the texture. You never know what will be called afterwards and it might expect it's GL_TEXTURE0.



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40273>

    any particular reason to explicitly set the true?



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40272>

    QScopedPointer?



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40274>

    empty newlines



src/declarativeimports/core/iconitem.h
<https://git.reviewboard.kde.org/r/116024/#comment40281>

    why additional new line?



src/declarativeimports/core/iconitem.h
<https://git.reviewboard.kde.org/r/116024/#comment40280>

    why is it moved around?



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40282>

    pedantic: move all the * one to right



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40277>

    coding style if( -> if (



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40279>

    ?



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/116024/#comment40278>

    ?


- Martin Gräßlin


On May 13, 2014, 1:09 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116024/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 1:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Port IconItem to native QSGTexture including the animation.
> This will save constantly uploading a new texture to OpenGL throughout the animation.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc 804529c 
>   CMakeLists.txt a726c75 
>   src/declarativeimports/core/CMakeLists.txt 9b3313d 
>   src/declarativeimports/core/fadingnode.cpp PRE-CREATION 
>   src/declarativeimports/core/fadingnode_p.h PRE-CREATION 
>   src/declarativeimports/core/iconitem.h 92a5233 
>   src/declarativeimports/core/iconitem.cpp 9cb487c 
> 
> Diff: https://git.reviewboard.kde.org/r/116024/diff/
> 
> 
> Testing
> -------
> 
> Test app: http://paste.kde.org/pl5pwdnel
> 
> Test app shows for lots of icons a decrease from 40 -> 27Mb
> apitrace has a lot fewer calls to glTexImage2D
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140513/a2f798cf/attachment-0001.html>