Review Request 116024: Port IconItem to native QSGTexture

[David Edmundson]

> On May 13, 2014, 12:47 p.m., Martin Gräßlin wrote:
> > src/declarativeimports/core/CMakeLists.txt, line 39
> > <https://git.reviewboard.kde.org/r/116024/diff/4/?file=272717#file272717line39>
> >
> >     why do you link against Qt5::OpenGL and find it? OpenGL is part of Gui

For anyone else who gets this problem:
QGlContext needs porting to QOpenGLContext which is in Gui.

Then you don't need to link OpenGL directly


> On May 13, 2014, 12:47 p.m., Martin Gräßlin wrote:
> > src/declarativeimports/core/fadingnode.cpp, lines 84-92
> > <https://git.reviewboard.kde.org/r/116024/diff/4/?file=272718#file272718line84>
> >
> >     I'd always activate the GL_TEXTURE0 texture target after setting the texture. You never know what will be called afterwards and it might expect it's GL_TEXTURE0.

I'm confused.
I need to set the active texture /before/ I bind to it.
Otherwise everything breaks.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/#review57872
-----------------------------------------------------------


On May 13, 2014, 3:25 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116024/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Port IconItem to native QSGTexture including the animation.
> This will save constantly uploading a new texture to OpenGL throughout the animation.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc 804529c 
>   src/declarativeimports/core/CMakeLists.txt 9b3313d 
>   src/declarativeimports/core/fadingnode.cpp PRE-CREATION 
>   src/declarativeimports/core/fadingnode_p.h PRE-CREATION 
>   src/declarativeimports/core/iconitem.h 92a5233 
>   src/declarativeimports/core/iconitem.cpp 9cb487c 
> 
> Diff: https://git.reviewboard.kde.org/r/116024/diff/
> 
> 
> Testing
> -------
> 
> Test app: http://paste.kde.org/pl5pwdnel
> 
> Test app shows for lots of icons a decrease from 40 -> 27Mb
> apitrace has a lot fewer calls to glTexImage2D
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140513/fac665eb/attachment-0001.html>