Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

[Gregor Mi]

> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
>     1. This is why I made it an option. :)
>     In my opinion, potentially private data should not be send to the internet without given the user the chance to know what is happening. When I was using pastebin the first time I was a bit surprised how quick the data went away.
>     Advanced users can easily disable this option. With the "do not ask again" method suggested by Dominik it should not hurt at all.
>     
>     2. Are you referring to the default width (or height) of 22.0 pixels? Or the widget geometry in general? Do you already have a "saner default" in mind?
>     
>     > complete rewrite as in Plasma 2, C++ plasmoids are not supported
>     Is plasma2 going to be released with KDE frameworks 5? Because there are still many c++ applets in the frameworks branch. So all of them have to be rewritten?
>
> 
> Aleix Pol Gonzalez wrote:
>     1. So you mean that only advanced users care about sharing too much data?
>     2. Well, I guess you added this option because the applet became huge, right?
>     
>     Yes, either the applets get rewritten or they die. And actually it's not a trivial task.
> 
> Dominik Haumann wrote:
>     Hi Aleix,
>     
>     to 1) I'm pretty sure this is not at all what Gregor wants to say. It's more like the behavior should be:
>     - On a fresh install, the message box asks you whether you really want to send the data.
>     - This message box always pops up, except if you
>       - either activated "[x] Don't show again",
>       - or you deactivated in the settings "[ ] Ask for confirmation"
>     
>     Granted, the code in the review request does not yet fully do that (as far as I can see), but this is totally NOT about "advanced users not careing about sharing too much data" ;)

to 1) Dominik is right.
to 2) Correct, I find the icon gets massively huge. :) I would very much welcome a saner default. But as with all defaults I guess this will be a big discussion. Maybe others like the huge icon? I would like to have the icons start stacking vertically if the certain panel width is reached as it is already done with the system tray icons (see http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png). Or do it like in Windows 7 (just have a thin button with no text or icon at all for the show desktop feature)?


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
-----------------------------------------------------------


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Summary
> -------
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels)
> 
> How does this change manifest on screen?
> ----------------------------------------
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>      - turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray)
>      - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space)
> 
> Open issues
> -----------
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin?
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> -------
> 
> See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140327/a5db4e1f/attachment-0001.html>