<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117041/">https://git.reviewboard.kde.org/r/117041/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2014, 12:41 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The frameworks version is ready, but the GUI is a complete rewrite as in Plasma 2, C++ plasmoids are not supported.
Personally, I don't think these options are needed:
1. I've never had a problem with accidentally sharing anything.
2. the plasmoid should have enough resources to know what size it should be. I would prefer a saner default.
Regarding the group, you should use plasma.</pre>
</blockquote>
<p>On March 25th, 2014, 10:20 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. This is why I made it an option. :)
In my opinion, potentially private data should not be send to the internet without given the user the chance to know what is happening. When I was using pastebin the first time I was a bit surprised how quick the data went away.
Advanced users can easily disable this option. With the "do not ask again" method suggested by Dominik it should not hurt at all.
2. Are you referring to the default width (or height) of 22.0 pixels? Or the widget geometry in general? Do you already have a "saner default" in mind?
> complete rewrite as in Plasma 2, C++ plasmoids are not supported
Is plasma2 going to be released with KDE frameworks 5? Because there are still many c++ applets in the frameworks branch. So all of them have to be rewritten?
</pre>
</blockquote>
<p>On March 25th, 2014, 10:45 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. So you mean that only advanced users care about sharing too much data?
2. Well, I guess you added this option because the applet became huge, right?
Yes, either the applets get rewritten or they die. And actually it's not a trivial task.</pre>
</blockquote>
<p>On March 26th, 2014, 9:20 a.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Aleix,
to 1) I'm pretty sure this is not at all what Gregor wants to say. It's more like the behavior should be:
- On a fresh install, the message box asks you whether you really want to send the data.
- This message box always pops up, except if you
- either activated "[x] Don't show again",
- or you deactivated in the settings "[ ] Ask for confirmation"
Granted, the code in the review request does not yet fully do that (as far as I can see), but this is totally NOT about "advanced users not careing about sharing too much data" ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">to 1) Dominik is right.
to 2) Correct, I find the icon gets massively huge. :) I would very much welcome a saner default. But as with all defaults I guess this will be a big discussion. Maybe others like the huge icon? I would like to have the icons start stacking vertically if the certain panel width is reached as it is already done with the system tray icons (see http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png). Or do it like in Windows 7 (just have a thin button with no text or icon at all for the show desktop feature)?</pre>
<br />
<p>- Gregor</p>
<br />
<p>On March 25th, 2014, 10:24 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated March 25, 2014, 10:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Summary
-------
Add two options:
1. Show confirmation before sending (to prevent accidental sending of maybe sensible data)
2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels)
How does this change manifest on screen?
----------------------------------------
Settings dialog:
- before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
- after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
Behaviour:
1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
2. "Appearance: Restrict width on large host panel"
- turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray)
- turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space)
Open issues
-----------
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request?
@apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/pastebin/pastebinConfig.ui <span style="color: grey">(540fae733c0ea738b48b3bf2b11b9f9b10bdb453)</span></li>
<li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/pastebin/pastebin.h <span style="color: grey">(931057f9df4f5e875f3984df1f40869235d8297e)</span></li>
<li>applets/pastebin/pastebin.cpp <span style="color: grey">(df7f534c17d5a383480f385b83948d01635641a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117041/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>