Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

[Gregor Mi]

> On March 25, 2014, 12:34 p.m., Dominik Haumann wrote:
> > applets/pastebin/pastebin.cpp, line 763
> > <https://git.reviewboard.kde.org/r/117041/diff/1/?file=256992#file256992line763>
> >
> >     You could use the dontAskAgainName here to add a checkbox to the dialog:
> >     KMessageBox::questionYesNo(
> >       QWidget *parent,
> >       const QString &text,
> >       const QString &caption=QString(),
> >       const KGuiItem &buttonYes
> >         = KStandardGuiItem::yes(),
> >       const KGuiItem &buttonNo
> >         = KStandardGuiItem::no(),
> >       const QString &dontAskAgainName
> >         = QString(),
> >       Options options=Notify)
> >     
> >     After this message box, you can check with shouldBeShownYesNo(...) whether for the checkbox result and adapt the variable m_configShowConfirmationBeforeSending, see
> >     http://api.kde.org/4.12-api/kdelibs-apidocs/kdeui/html/kmessagebox_8h_source.html
> >     for existing methods.
> 
> Gregor Mi wrote:
>     Thanks for the hint. I'll try to implement it.
> 
> Gregor Mi wrote:
>     By trying I found out that the dontAskAgain thing makes no sense here because the user is asked TWO questions:
>     1. "Should the data be sent?"
>     2. "Would you like to see the message next time?"
>     This cannot be done with a single message box, right?
>     So I'll change the messagebox text to "Data is about to be sent to the internet. Continue?\r\r(You can disable this message in the applet settings)"

Clarification of the previous post: What should be done if the user chooses "No" and checks the "dont ask again" box? Should be data then NOT be sent next time (which would render the applet useless)? Or should the "dont ask again" choice be ignored in this case (which seems not the right way how to use this functionality)?


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54097
-----------------------------------------------------------


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Summary
> -------
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels)
> 
> How does this change manifest on screen?
> ----------------------------------------
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>      - turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray)
>      - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space)
> 
> Open issues
> -----------
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin?
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> -------
> 
> See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140327/0b014e66/attachment.html>