<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117041/">https://git.reviewboard.kde.org/r/117041/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2014, 12:34 p.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117041/diff/1/?file=256992#file256992line763" style="color: black; font-weight: bold; text-decoration: underline;">applets/pastebin/pastebin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Pastebin::postClipboard(bool preferSelection)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">763</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_configShowConfirmationBeforeSending</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could use the dontAskAgainName here to add a checkbox to the dialog:
KMessageBox::questionYesNo(
QWidget *parent,
const QString &text,
const QString &caption=QString(),
const KGuiItem &buttonYes
= KStandardGuiItem::yes(),
const KGuiItem &buttonNo
= KStandardGuiItem::no(),
const QString &dontAskAgainName
= QString(),
Options options=Notify)
After this message box, you can check with shouldBeShownYesNo(...) whether for the checkbox result and adapt the variable m_configShowConfirmationBeforeSending, see
http://api.kde.org/4.12-api/kdelibs-apidocs/kdeui/html/kmessagebox_8h_source.html
for existing methods.</pre>
</blockquote>
<p>On March 25th, 2014, 10:23 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the hint. I'll try to implement it.</pre>
</blockquote>
<p>On March 27th, 2014, 11:21 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">By trying I found out that the dontAskAgain thing makes no sense here because the user is asked TWO questions:
1. "Should the data be sent?"
2. "Would you like to see the message next time?"
This cannot be done with a single message box, right?
So I'll change the messagebox text to "Data is about to be sent to the internet. Continue?\r\r(You can disable this message in the applet settings)"</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clarification of the previous post: What should be done if the user chooses "No" and checks the "dont ask again" box? Should be data then NOT be sent next time (which would render the applet useless)? Or should the "dont ask again" choice be ignored in this case (which seems not the right way how to use this functionality)?</pre>
<br />
<p>- Gregor</p>
<br />
<p>On March 25th, 2014, 10:24 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated March 25, 2014, 10:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Summary
-------
Add two options:
1. Show confirmation before sending (to prevent accidental sending of maybe sensible data)
2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels)
How does this change manifest on screen?
----------------------------------------
Settings dialog:
- before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
- after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
Behaviour:
1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
2. "Appearance: Restrict width on large host panel"
- turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray)
- turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space)
Open issues
-----------
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request?
@apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/pastebin/pastebinConfig.ui <span style="color: grey">(540fae733c0ea738b48b3bf2b11b9f9b10bdb453)</span></li>
<li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/pastebin/pastebin.h <span style="color: grey">(931057f9df4f5e875f3984df1f40869235d8297e)</span></li>
<li>applets/pastebin/pastebin.cpp <span style="color: grey">(df7f534c17d5a383480f385b83948d01635641a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117041/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>