Review Request 118661: Only find Qt5::X11Extras if X11 is found

[Martin Gräßlin]

> On June 11, 2014, 11 a.m., David Edmundson wrote:
> > If you do this we need checks around building everything that tries to link against it otherwise you get mystery compile fails.
> > There's 2 applets and 9 KCMs
> 
> Martin Gräßlin wrote:
>     they should already have these checks otherwise the check for X11 is kind of pointless.
> 
> David Edmundson wrote:
>     I haven't checked all of them, but the TaskManager applet doesn't look to check.

* applets/pager: if(NOT WIN32) and if(KF5Activities_FOUND) - should be fine
* applets/taskmanager: if(NOT WIN32) - should be fine
* kcm/access: if(NOT WIN32) - should be fine
* kcm/bell: if(NOT WIN32) - should be fine
* kcm/colors: if(X11_FOUND) around X11Extras, but broken nevertheless as unconditionally linking to X11Libraries
* kcm/componentchoser: if(X11_FOUND)
* kcm/fonts: if(X11_FOUND)
* kcm/input: broken
* kcm/keyboard: if(X11_Xkb_FOUND AND XCB_XKB_FOUND)
* kcm/kfontinst: if(FONTCONFIG_FOUND AND FREETYPE_FOUND AND NOT WIN32)
* kcm/style: broken


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118661/#review59752
-----------------------------------------------------------


On June 11, 2014, 10:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118661/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 10:44 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Only find Qt5::X11Extras if X11 is found
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 399de771e17b265c1e5a223ad128ae2d17c00d22 
> 
> Diff: https://git.reviewboard.kde.org/r/118661/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140611/29d1dea3/attachment.html>