Review Request 118661: Only find Qt5::X11Extras if X11 is found
David Edmundson
david at davidedmundson.co.uk
Wed Jun 11 09:10:11 UTC 2014
> On June 11, 2014, 9 a.m., David Edmundson wrote:
> > If you do this we need checks around building everything that tries to link against it otherwise you get mystery compile fails.
> > There's 2 applets and 9 KCMs
>
> Martin Gräßlin wrote:
> they should already have these checks otherwise the check for X11 is kind of pointless.
I haven't checked all of them, but the TaskManager applet doesn't look to check.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118661/#review59752
-----------------------------------------------------------
On June 11, 2014, 8:44 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118661/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 8:44 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Only find Qt5::X11Extras if X11 is found
>
>
> Diffs
> -----
>
> CMakeLists.txt 399de771e17b265c1e5a223ad128ae2d17c00d22
>
> Diff: https://git.reviewboard.kde.org/r/118661/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140611/051030b7/attachment-0001.html>
More information about the Plasma-devel
mailing list